Skip to content

bugfix draw function for modules#344

Merged
MaximilianSoerenPollak merged 5 commits intoeclipse-score:mainfrom
etas-contrib:bug_provent_return_modview_as_mod
Jan 14, 2026
Merged

bugfix draw function for modules#344
MaximilianSoerenPollak merged 5 commits intoeclipse-score:mainfrom
etas-contrib:bug_provent_return_modview_as_mod

Conversation

@RolandJentschETAS
Copy link
Contributor

@RolandJentschETAS RolandJentschETAS commented Jan 14, 2026

📌 Description

Fix draw function for module in case multiple links are on module.

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions
Copy link

github-actions bot commented Jan 14, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 49d2dd07-6b31-4bf8-9d59-fd6f36aaf2e8
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (64 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (123 packages loaded, 1901 targets configured)

Analyzing: target //src:license-check (134 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
[6 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 14.996s, Critical Path: 0.32s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Jan 14, 2026

The created documentation from the pull request is available at: docu-html

MaximilianSoerenPollak
MaximilianSoerenPollak reviewed Jan 14, 2026
View reviewed changes
src/extensions/score_draw_uml_funcs/helpers.py Outdated
# includes_back could deliver multiple needs; onlyreturn Modules
parents = need.get("includes_back", [])
if isinstance(parents, str):
parents = [parents]
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this not automatically be a list according to sphinx_needs?

So would this then make it a double list? [[parents]] if 'parents` itself already is a list?
Is this the wanted behaviour?

Copy link
Contributor Author

@RolandJentschETAS RolandJentschETAS Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is unnecessary.

Copy link
Contributor Author

@RolandJentschETAS RolandJentschETAS Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and add warning.

MaximilianSoerenPollak
MaximilianSoerenPollak approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay from my side.

MaximilianSoerenPollak
MaximilianSoerenPollak reviewed Jan 14, 2026
View reviewed changes
src/extensions/score_draw_uml_funcs/helpers.py

if len(module) > 1:
logger.warning(
f"{component}: included in multiple modules: {module}. Returning first."
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be fixed in future PR.

Is it somewhere documented why only the first one is returned?
Or what the logic behind it is?

Copy link
Contributor Author

@RolandJentschETAS RolandJentschETAS Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the implicit logic, that a component belongs only to one module. Module is something like a bazel module or a package. And the component should only be in one. Sure, it could be used or integrated in more then one, but the real implementation should only be in one. I'm not sure if there are any circumstances (base libraries ???) for an exception from this rule, therefore I give only the warning. But in general it is only one. If we want to modify the draw function to show also multiple modules, then I guess more have to be changed. But will discuss this with the colleagues.

@MaximilianSoerenPollak MaximilianSoerenPollak merged commit aa24fdf into eclipse-score:main Jan 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaximilianSoerenPollak MaximilianSoerenPollak MaximilianSoerenPollak approved these changes

@AlexanderLanin AlexanderLanin Awaiting requested review from AlexanderLanin AlexanderLanin is a code owner

@dcalavrezo-qorix dcalavrezo-qorix Awaiting requested review from dcalavrezo-qorix dcalavrezo-qorix is a code owner

@nradakovic nradakovic Awaiting requested review from nradakovic nradakovic is a code owner

Assignees

No one assigned

Labels

None yet

Projects

INF - Infrastructure Community
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RolandJentschETAS @MaximilianSoerenPollak